rename SignalWith track method #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it better to only keep one of them? |
|
Or give track its own trait SignalTrack? |
|
Hmm yeah it's own trait would probably be good |
jrmoulton
added a commit
to jrmoulton/floem
that referenced
this pull request
Sep 9, 2024
* rename SignalWith track method * add SignalTrack trait
jrmoulton
added a commit
to jrmoulton/floem
that referenced
this pull request
Sep 9, 2024
vello w/ gradients and brush override vello chnages. before parley attempt parley Revert "attempt parley" This reverts commit 851ae9d8067e1ec570bed4fa865980f6b10ba33b. wip updates wip wip wip new vello fixed lapce#554 (lapce#555) - fixed tab navigation wrapping the tab button - fixed lapce#554 Add SignalGet SignalWith SignalUpdate traits (lapce#558) * Add SignalGet SignalWith SignalUpdate traits * fix doc * fix Linux make SignalUpdate non panic Add initial wasm support (lapce#527) * Add initial wasm support * Bump web-time version * Run cargo fmt * Fix webgpu example * Fix clippy warning * Switch to latest floem-winit commit * Fix conditional import in keyboard.rs * Fix webgpu example * Automatically follow canvas size by default * Remove unused import * Remove unused import * Use latest floem-vger from git add get/update from fn (lapce#559) * add get/update from fn * update radio buttons and example * Add stack ext trait * update dropdown * change custom constructors return self to allow custom styles * fix flight booker * fix other examples * better support for simple closure input * fix clippy rename SignalWith track method (lapce#562) * rename SignalWith track method * add SignalTrack trait Keyframe Animations (lapce#563) * add keyframed animations * Make animations reactive and stackable * remove old files * fix bezier * add reactive animation state control * remove animation message comment * improve easing * clippy * add delay * Fix transition on layout props * Fix animate towards default * fix animation view state * fix animation view state again * fix clippy * remove old comment * fix clippy 2
jrmoulton
added a commit
to jrmoulton/floem
that referenced
this pull request
Sep 9, 2024
vello w/ gradients and brush override vello chnages. before parley attempt parley Revert "attempt parley" This reverts commit 851ae9d8067e1ec570bed4fa865980f6b10ba33b. wip updates wip wip wip new vello fixed lapce#554 (lapce#555) - fixed tab navigation wrapping the tab button - fixed lapce#554 Add SignalGet SignalWith SignalUpdate traits (lapce#558) * Add SignalGet SignalWith SignalUpdate traits * fix doc * fix Linux make SignalUpdate non panic Add initial wasm support (lapce#527) * Add initial wasm support * Bump web-time version * Run cargo fmt * Fix webgpu example * Fix clippy warning * Switch to latest floem-winit commit * Fix conditional import in keyboard.rs * Fix webgpu example * Automatically follow canvas size by default * Remove unused import * Remove unused import * Use latest floem-vger from git add get/update from fn (lapce#559) * add get/update from fn * update radio buttons and example * Add stack ext trait * update dropdown * change custom constructors return self to allow custom styles * fix flight booker * fix other examples * better support for simple closure input * fix clippy rename SignalWith track method (lapce#562) * rename SignalWith track method * add SignalTrack trait Keyframe Animations (lapce#563) * add keyframed animations * Make animations reactive and stackable * remove old files * fix bezier * add reactive animation state control * remove animation message comment * improve easing * clippy * add delay * Fix transition on layout props * Fix animate towards default * fix animation view state * fix animation view state again * fix clippy * remove old comment * fix clippy 2
jrmoulton
added a commit
to jrmoulton/floem
that referenced
this pull request
Sep 26, 2024
* rename SignalWith track method * add SignalTrack trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids naming conflicts with the SignalRead track method