introduce convert_to_secret() to bananadev llm #14283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tholapz
commented
Dec 5, 2023
tholapz
commented
- Description: Per For New Contributors: Use SecretStr for api_keys #12165, this PR add to BananaLLM the function convert_to_secret_str() during environment variable validation.
- Issue: For New Contributors: Use SecretStr for api_keys #12165
- Tag maintainer: @eyurtsev
- Twitter handle: @treewatcha75751
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
hwchase17
reviewed
Dec 6, 2023
There was a problem hiding this comment.
can we add a test, and i also think we need to call .get_secret_value() wherever this is used
see https://github.com/langchain-ai/langchain/pull/14309/files for a good example
dosubot
bot
added
size:M
use convert_to_secret_str() util create unit tests
|
@hwchase17 please re-review. Thanks! |
baskaryan
approved these changes
Mar 30, 2024
dosubot
bot
added
the
lgtm
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…gchain-ai#14283) - **Description:** Per langchain-ai#12165, this PR add to BananaLLM the function convert_to_secret_str() during environment variable validation. - **Issue:** langchain-ai#12165 - **Tag maintainer:** @eyurtsev - **Twitter handle:** @treewatcha75751 --------- Co-authored-by: Bagatur <[email protected]>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
) - **Description:** Per #12165, this PR add to BananaLLM the function convert_to_secret_str() during environment variable validation. - **Issue:** #12165 - **Tag maintainer:** @eyurtsev - **Twitter handle:** @treewatcha75751 --------- Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.