Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an IMDb toolkit #14105

Closed
wants to merge 38 commits into from
Closed

Added an IMDb toolkit #14105

wants to merge 38 commits into from

Conversation

STalukder20
Copy link

Adds support for an IMDb toolkit. Agents should now be able to retrieve up-to-date information from IMDb.

Issue #11926

Dependencies

jesseyao89 and others added 30 commits November 16, 2023 22:23
Add IMDb base tool and movie search tool
Cast and plot of movie implementation
…t explaining dummy input in IMDbPopularMovies
Linting changes, and try/catch for movie name instead of ID error.
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 1, 2023
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:09pm

@dosubot dosubot bot added Ɑ: agent Related to agents module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Dec 1, 2023
@@ -147,6 +147,8 @@ praw = {version = "^7.7.1", optional = true}
msal = {version = "^1.25.0", optional = true}
databricks-vectorsearch = {version = "^0.21", optional = true}
dgml-utils = {version = "^0.3.0", optional = true}
cinemagoer = {git = "https://github.com/cinemagoer/cinemagoer", optional = true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there's a published version of the package, any reason not to use that? https://pypi.org/project/cinemagoer/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we had issues getting the published version of Cinemagoer to work reliably, which went away once we started installing the package directly from the repository. Installing from the repo does seem to be the preferred installation method, as indicated in the documentation: https://cinemagoer.readthedocs.io/en/latest/#installation

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 3, 2023
@baskaryan
Copy link
Collaborator

looks like you've got some merge conflicts, but otherwise good to go!

@dosubot dosubot bot removed the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 4, 2023
@jesseyao89
Copy link

Conflicts resolved 👍

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 6, 2023
@hwchase17 hwchase17 closed this Jan 30, 2024
@baskaryan baskaryan reopened this Jan 30, 2024
@ccurme ccurme added the langchain Related to the langchain package label Jun 21, 2024
@ccurme ccurme added community Related to langchain-community and removed langchain Related to the langchain package labels Jul 19, 2024
@langcarl
Copy link

langcarl bot commented Nov 4, 2024

Thank you for the PR. This PR is marked Needs Support and has not yet received the 5 upvotes required by maintainers for review. It has been open for at least 25 days. Per the LangChain review process, this PR will be closed in 5 days if it does not reach the required threshold.

The Needs Support status is intended to prioritize review time on features that have demonstrated community support. If you feel this status was assigned in error or need more time to gather the required upvotes, please ping (at)ccurme and (at)efriis.

@langcarl langcarl bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 4, 2024
@langcarl langcarl bot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: agent Related to agents module community Related to langchain-community 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files. stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants