-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an IMDb toolkit #14105
Added an IMDb toolkit #14105
Conversation
Add IMDb base tool and movie search tool
Cast and plot of movie implementation
…t explaining dummy input in IMDbPopularMovies
Linting changes, and try/catch for movie name instead of ID error.
Add more tools
Imdb feature and toolkit
Added imdb.ipynb
Final cleanup
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -147,6 +147,8 @@ praw = {version = "^7.7.1", optional = true} | |||
msal = {version = "^1.25.0", optional = true} | |||
databricks-vectorsearch = {version = "^0.21", optional = true} | |||
dgml-utils = {version = "^0.3.0", optional = true} | |||
cinemagoer = {git = "https://github.com/cinemagoer/cinemagoer", optional = true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like there's a published version of the package, any reason not to use that? https://pypi.org/project/cinemagoer/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we had issues getting the published version of Cinemagoer to work reliably, which went away once we started installing the package directly from the repository. Installing from the repo does seem to be the preferred installation method, as indicated in the documentation: https://cinemagoer.readthedocs.io/en/latest/#installation
looks like you've got some merge conflicts, but otherwise good to go! |
Conflicts resolved 👍 |
Thank you for the PR. This PR is marked The |
Adds support for an IMDb toolkit. Agents should now be able to retrieve up-to-date information from IMDb.
Issue #11926
Dependencies