-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: insert api for HNSW #2395
base: main
Are you sure you want to change the base?
Conversation
ACTION NEEDED Lance follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 79.70% 79.73% +0.02%
==========================================
Files 200 200
Lines 54937 55015 +78
Branches 54937 55015 +78
==========================================
+ Hits 43788 43864 +76
- Misses 8609 8612 +3
+ Partials 2540 2539 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We didn't previously have a way of inserting into HNSW post-build.
There's an important aspect to how this works without affecting performance:
This will result in a brief slow-down whenever the size overflows, so latency of inserts (and also queries) will very occasionally spike briefly, but with smaller and smaller frequency as the graph size grows.