hook up feature only in python releases

lancedb · Dec 5, 2024 · 89f0d34 · 89f0d34
1 parent a0f7936
commit 89f0d34
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml
@@ -17,7 +17,7 @@ jobs:
             extra_args: ""
           - platform: x86_64
             manylinux: "2_28"
-            extra_args: "--features fp16kernels"
+            extra_args: "--features fp16kernels,error_location_github"
           - platform: aarch64
             manylinux: "2_24"
             extra_args: ""
@@ -96,7 +96,7 @@ jobs:
     - uses: ./.github/workflows/build_mac_wheel
       with:
         python-minor-version: ${{ matrix.python-minor-version }}
-        args: "--release --strip --target ${{ matrix.config.target }} --features fp16kernels"
+        args: "--release --strip --target ${{ matrix.config.target }} --features fp16kernels,error_location_github"
     - uses: ./.github/workflows/upload_wheel
       with:
         pypi_token: ${{ secrets.PYPI_TOKEN }}

diff --git a/python/Cargo.toml b/python/Cargo.toml
@@ -63,6 +63,7 @@ bytes = "1.4"
 [features]
 datagen = ["lance-datagen"]
 fp16kernels = ["lance/fp16kernels"]
+error_location_github = ["lance-core/error_location_github"]
 
 [build-dependencies]
 prost-build = "0.11"
diff --git a/rust/lance-core/Cargo.toml b/rust/lance-core/Cargo.toml
@@ -53,7 +53,7 @@ lance-testing.workspace = true
 proptest.workspace = true
 
 [features]
-default = ["error_location_github"]
+default = []
 datafusion = ["datafusion-common", "datafusion-sql"]
 error_location_github = []