Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report correct location on a repeat modifier #17982

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: report correct location on a repeat modifier #17982

merged 1 commit into from
Jun 19, 2023

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Jun 15, 2023 •
edited
Loading

Currently given the following code snippet:

final final case class Foo()

The error is reported on Foo and not on the repeated modifier. This changes the reporting to instead report on the repeated modifier final.

Fixes #17981

@ckipp01
fix: report correct location on a repeat modifier
e2d35cc 
Currently given the following code snippet:

```scala
final final case class Foo()
```

The error is reported on `Foo` and not on the repeated modifier. This
change change the reporting to instead report on the repeated modifier
`final`.

Fixes scala#17981
@sjrd
Copy link
Member

sjrd commented Jun 15, 2023

This change change the reporting

🤣

@ckipp01
Copy link
Member Author

ckipp01 commented Jun 15, 2023 •
edited
Loading

This change change the reporting

🤣

Ugh, I'm a native English speaker, and I still can't speak English.

mbovel
mbovel approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the Dotty meeting :)

@ckipp01 ckipp01 merged commit 10180da into scala:main Jun 19, 2023
@ckipp01 ckipp01 deleted the badModifier branch June 19, 2023 13:32
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
@rochala rochala added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 5, 2023
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan mentioned this pull request Nov 23, 2023
Merged
Kordyjan pushed a commit that referenced this pull request Nov 23, 2023
@ckipp01 @Kordyjan
fix: report correct location on a repeat modifier (#17982)
d5e981f 
Currently given the following code snippet:

```scala
final final case class Foo()
```

The error is reported on `Foo` and not on the repeated modifier. This
changes the reporting to instead report on the repeated modifier
`final`.

Fixes #17981
[Cherry-picked 10180da]
Kordyjan pushed a commit that referenced this pull request Nov 29, 2023
@ckipp01 @Kordyjan
fix: report correct location on a repeat modifier (#17982)
6fb812a 
Currently given the following code snippet:

```scala
final final case class Foo()
```

The error is reported on `Foo` and not on the repeated modifier. This
changes the reporting to instead report on the repeated modifier
`final`.

Fixes #17981
[Cherry-picked 10180da]
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "fix: report correct location on a repeat modifier" to LTS (#…
fd42513 
…19026)

Backports #17982 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan modified the milestones: 3.4.0, 3.3.2 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbovel mbovel mbovel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

Incorect location for diagnostic on repeated modifier
5 participants
@ckipp01 @sjrd @mbovel @Kordyjan @rochala