Updating dependencies and docker builds #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laixintao it doesn't look like these changes impact the reasons they're falling. But, I'd love your feedback! |
|
sorry for the late reply. thank you! looks good. but can you add Python11 into the CI and remove python3.6? |
|
@laixintao There is no python 3.6, we now have 3.11, and 3.12. |
|
The CI failed may be due to you upgraded redis-py. Let me merge it first then fix the ci later. |
laixintao
added a commit
that referenced
this pull request
Oct 30, 2023
see: python-pendulum/pendulum#600 this will revert part of #461
|
Hi @chayim sorry seems pendulum didn't support py312 yet, so I have to cancel py312 support for now until pendulum 3 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the dependencies to use the latest redis-py, as well as the docker build to run redis-stack. Along the way, I added iredis as a binary, and changed how things launch, added the python 3.11 trove. Finally, the README was updated to remove the python 3.6 badge, given that the pyproject.toml already deprecated 3.6. closes #448