Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2 test fix #1723

Merged
merged 6 commits into from
May 8, 2022
Merged

http2 test fix #1723

merged 6 commits into from
May 8, 2022

Conversation

yunnysunny
Copy link
Contributor

Fix the test on http2.

  1. There is an issue in express-session No need to call undocumented nodejs function ServerResponse._implicitHeader expressjs/session#888 , it call _implicitHeader on Http2ServerResponse, which is not exist. So I add a property named _implicitHeader on Http2ServerResponse in test file test/node/agency.js.
  2. The test/support/express/responseDecorator.js call the package statuses in wrong way. So I fixed it.
  3. All node version will try to test on http2 now.
  4. There an confused test case in test/node/http2.js , I have no idea what it wanna test. So I skp it.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #1723 (b8bf5e8) into master (34c9ff4) will increase coverage by 7.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
+ Coverage   86.76%   94.08%   +7.32%     
==========================================
  Files          14       14              
  Lines        1133     1133              
==========================================
+ Hits          983     1066      +83     
+ Misses        150       67      -83     
Impacted Files Coverage Δ
src/node/index.js 93.64% <0.00%> (+0.37%) ⬆️
src/node/http2wrapper.js 96.29% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c9ff4...b8bf5e8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants