-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for old version Node #1722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
==========================================
+ Coverage 86.67% 86.76% +0.08%
==========================================
Files 14 14
Lines 1133 1133
==========================================
+ Hits 982 983 +1
+ Misses 151 150 -1
Continue to review full report at Codecov.
|
This broke my CI, I don't think this is a good change. |
Agreed |
v7.1.5 released to npm (note the tests are broken until someone rewrites them) https://github.com/visionmedia/superagent/releases/tag/v7.1.5 |
The fix has supplied. #1729 |
Some version of development packages we used is not suitable for old version node. This packages include eslint commitlint husky remark-cli xo. I moved all these to optional dependencies . And now we can install dependencies via
yarn install --ignore-optional
to skip the installing of incompatible packages.And I also found the files in test folder can't been run on old version Node, so I transform them to ES5 files via bable.