-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/GitHub action improve #1717
Feature/GitHub action improve #1717
Conversation
yunnysunny
commented
Apr 3, 2022
- Tigger CI on push and pull request event.
- Replace the config of sauce with github action secret enviroment variables.
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 14 14
Lines 1133 1133
=======================================
Hits 982 982
Misses 151 151 Continue to review full report at Codecov.
|
|
||
env: | ||
SAUCE_USERNAME: shtylman-superagent | ||
SAUCE_ACCESS_KEY: 39a45464-cb1d-4b8d-aa1f-83c7c04fa673 | ||
SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 great! after this is resolved, probably want to rotate these credentials.
I don't know this project well, but I see the timeout bump in #1716. It looks though like this value is overridden in the vast majority of these tests (including the one that fails here if I'm reading correctly). You may need to do something like the following instead:
Again, not super sure of conventions (e.g. repo seems to use a lot of |
I has reset the parameter of timeout to 5000, and used timeout function to set pipe testcase separately. |