Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lookup method #1595

Merged
merged 1 commit into from
Jan 18, 2022
Merged

feat: add lookup method #1595

merged 1 commit into from
Jan 18, 2022

Conversation

yunnysunny
Copy link
Contributor

Add the feature of custom DNS resolve in node.
Sometime we use custom DNS to do service discovery, but superagent doesn't have the ability of changing the lookup method when call node's http.request method.
So I pull this request to solve the problem.

@niftylettuce niftylettuce merged commit df06131 into ladjs:master Jan 18, 2022
@niftylettuce
Copy link
Collaborator

@niftylettuce
Copy link
Collaborator

This caused a break in v7.1.0 and I had to revert in v7.1.1

#1673

Please submit a new PR with the fix when you can, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants