Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: count from lacework_external_id resource #110

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Oct 12, 2023

Summary

If a user is chaining modules to create a single IAM role and passing the external id from the IAM Role module, Terraform will error with:

The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created.

Example Gist of how to chain ALL our AWS modules to deploy Lacework.

https://gist.github.com/afiune/08a4ef4547dab13ce2c1367a122543a6

How did you test this change?

Used the Gist to deploy all integrations into a single AWS account

Issue

https://lacework.atlassian.net/browse/GROW-2468

If a user is chaining modules to create a single IAM role and passing the external id from the IAM Role module, Terraform will error with:
```
The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created.
```

Example Gist of how to chain ALL our AWS modules to deploy Lacework.

https://gist.github.com/afiune/08a4ef4547dab13ce2c1367a122543a6

Signed-off-by: Salim Afiune Maya <[email protected]>
@afiune afiune changed the title fix: remove count from lacework_external_id resource fix: count from lacework_external_id resource Oct 13, 2023
@afiune afiune merged commit b7bc7e2 into main Oct 16, 2023
1 check passed
@afiune afiune deleted the afiune-patch-1 branch October 16, 2023 02:27
@lacework-releng lacework-releng mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants