Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session status_info not reflecting batch failures #3085

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 12, 2024

Currently, the status_info column in the sessions table is being set to the same value regardless of batch execution result. Only the result column reflects the result as updating the value to "SUCCESS" or "FAILURE"
Let's update the status_info column to the reason value of Session result events.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

Copy link
Member Author

fregataa commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fregataa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added comp:manager Related to Manager component size:S 10~30 LoC labels Nov 12, 2024
@fregataa fregataa changed the title fix: session status_info not reflecting batch failures fix: session status_info not reflecting batch failures Nov 12, 2024
@fregataa fregataa added this to the 24.03 milestone Nov 12, 2024
@fregataa fregataa marked this pull request as ready for review November 12, 2024 07:55
@fregataa fregataa force-pushed the topic/11-12-fix_session_status_info_not_reflecting_batch_failures branch from e948dd1 to c597151 Compare November 12, 2024 08:02
@fregataa fregataa modified the milestones: 24.03, 23.09 Nov 13, 2024
@fregataa fregataa requested a review from rapsealk November 13, 2024 08:23
@fregataa fregataa added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit fe57e64 Nov 13, 2024
26 checks passed
@fregataa fregataa deleted the topic/11-12-fix_session_status_info_not_reflecting_batch_failures branch November 13, 2024 08:34
lablup-octodog pushed a commit that referenced this pull request Nov 13, 2024
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3085
lablup-octodog pushed a commit that referenced this pull request Nov 13, 2024
Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3085
lablup-octodog pushed a commit that referenced this pull request Nov 13, 2024
Backported-from: main (24.12)
Backported-to: 23.09
Backport-of: 3085
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
achimnol pushed a commit that referenced this pull request Nov 17, 2024
Backported-from: main (24.12)
Backported-to: 23.09
Backport-of: 3085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant