-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: session status_info
not reflecting batch failures
#3085
Merged
fregataa
merged 2 commits into
main
from
topic/11-12-fix_session_status_info_not_reflecting_batch_failures
Nov 13, 2024
Merged
fix: session status_info
not reflecting batch failures
#3085
fregataa
merged 2 commits into
main
from
topic/11-12-fix_session_status_info_not_reflecting_batch_failures
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
comp:manager
Related to Manager component
size:S
10~30 LoC
labels
Nov 12, 2024
4 tasks
fregataa
changed the title
fix: session status_info not reflecting batch failures
fix: session Nov 12, 2024
status_info
not reflecting batch failures
fregataa
force-pushed
the
topic/11-12-fix_session_status_info_not_reflecting_batch_failures
branch
from
November 12, 2024 08:02
e948dd1
to
c597151
Compare
fregataa
deleted the
topic/11-12-fix_session_status_info_not_reflecting_batch_failures
branch
November 13, 2024 08:34
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 13, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3085
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 13, 2024
Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 3085
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 13, 2024
Backported-from: main (24.12) Backported-to: 23.09 Backport-of: 3085
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Sanghun Lee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Sanghun Lee <[email protected]>
achimnol
pushed a commit
that referenced
this pull request
Nov 17, 2024
Backported-from: main (24.12) Backported-to: 23.09 Backport-of: 3085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
status_info
column in the sessions table is being set to the same value regardless of batch execution result. Only theresult
column reflects the result as updating the value to "SUCCESS" or "FAILURE"Let's update the
status_info
column to the reason value of Session result events.Checklist: (if applicable)