Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose 'version' element has been deprecated and shows up with an obsoleted error #2034

Closed
studioego opened this issue Apr 18, 2024 · 1 comment · Fixed by #2035
Closed
Assignees
Labels
area:docs Documentations

Comments

@studioego
Copy link
Contributor

Main idea

Docker compose 'version' element has been deprecated and shows up with an obsoleted error.

Example)

bai@dhsung:~/halfstack/postgres-cluster-default$ docker compose up -d
WARN[0000] /home/bai/halfstack/postgres-cluster-default/docker-compose.yaml: `version` is obsolete
[+] Running 9/9
 ✔ backendai-pg-active Pulled                                                                19.1s
   ✔ 8921db27df28 Pull complete                                                               2.9s
   ✔ eb286326f602 Pull complete                                                               1.5s
   ✔ 63139c77dd7e Pull complete                                                               0.7s
   ✔ a9743166247f Pull complete                                                               5.0s
   ✔ 74511a0f4fff Pull complete                                                               2.4s
   ✔ ff50ec8f35d1 Pull complete                                                               3.2s
   ✔ a0a3210db3fb Pull complete                                                               3.9s
   ✔ 5a297527e76d Pull complete                                                               4.6s
[+] Running 2/2
 ✔ Network postgres-cluster-default_half_stack               Created                          0.2s
 ✔ Container postgres-cluster-default-backendai-pg-active-1  Started                          0.3s
bai@dhsung:~/halfstack/redis-cluster-default$ docker compose up -d
WARN[0000] /home/bai/halfstack/redis-cluster-default/docker-compose.yaml: `version` is obsolete
[+] Running 9/9
 ✔ backendai-halfstack-redis Pulled                                                            9.3s
   ✔ 4abcf2066143 Pull complete                                                                3.0s
   ✔ 2c3a1d240687 Pull complete                                                                3.6s
   ✔ 643f361aa308 Pull complete                                                                3.0s
   ✔ a693cf0e318c Pull complete                                                                3.4s
   ✔ ade57efb0b22 Pull complete                                                                5.0s
   ✔ 2fa2e1566407 Pull complete                                                                3.7s
   ✔ 4f4fb700ef54 Pull complete                                                                4.5s
   ✔ 4464e0709769 Pull complete                                                                5.2s
[+] Running 2/2
 ✔ Network redis-cluster-default_half_stack                     Created                        0.2s
 ✔ Container redis-cluster-default-backendai-halfstack-redis-1  Started                        0.1s

image

https://github.com/lablup/backend.ai/blob/main/docs/install/install-from-package/prepare-cache-service.rst
https://github.com/lablup/backend.ai/blob/main/docs/install/install-from-package/prepare-database.rst

Following the document https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element ,
The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative.

As a result, docker-compose.yaml like files need to remove deprecated top-level version element.

Alternative ideas

No response

Anything else?

Reference Issues

@studioego studioego added type:feature Add new features area:docs Documentations labels Apr 18, 2024
@studioego studioego self-assigned this Apr 18, 2024
studioego added a commit that referenced this issue Apr 18, 2024
Docker compose 'version' element has been deprecated and shows up with an obsoleted error.

On the install from Package guide, remove docker compose top-level element 'version'

Following the document https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element ,
The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative.

As a result, On the install from Package documents need to remove deprecated top-level version element.

Fixed #2034
adrysn pushed a commit that referenced this issue Apr 25, 2024
Docker compose 'version' element has been deprecated and shows up with an obsoleted error.

On the install from Package guide, remove docker compose top-level element 'version'

Following the document https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element , The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative.

As a result, On the install from Package documents need to remove deprecated top-level version element.

Fixed #2034

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Milestone metadata specifying the target backport version
- [ ] Mention to the original issue
- [ ] Installer updates including:
  - Fixtures for db schema changes
  - New mandatory config options
- [ ] Update of end-to-end CLI integration tests in `ai.backend.test`
- [ ] API server-client counterparts (e.g., manager API -> client SDK)
- [ ] Test case(s) to:
  - Demonstrate the difference of before/after
  - Demonstrate the flow of abstract/conceptual models with a concrete implementation
- [ v ] Documentation
  - Contents in the `docs` directory
  - docstrings in public interfaces and type annotations

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2035.org.readthedocs.build/en/2035/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2035.org.readthedocs.build/ko/2035/

<!-- readthedocs-preview sorna-ko end -->
@studioego
Copy link
Contributor Author

Resolve it. then close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants