feat: add batch job timeout duration #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
force-pushed
the
feature/batch-session-timeout
branch
from
e5bf63c to
f2c5d1b
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.26% | 386/7332 |
| 🔴 | Branches | 4.52% | 229/5062 |
| 🔴 | Functions | 3.14% | 76/2418 |
| 🔴 | Lines | 5.17% | 371/7171 |
Test suite run success
109 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from b082f8a
agatha197
force-pushed
the
feature/batch-session-timeout
branch
from
f2c5d1b to
2fded01
Compare
github-actions
bot
added
area:ux
agatha197
changed the title
agatha197
force-pushed
the
feature/batch-session-timeout
branch
2 times, most recently
from
8facaeb to
8c3cb7d
Compare
agatha197
added
the
urgency:4
Graphite App
agatha197
force-pushed
the
feature/batch-session-timeout
branch
2 times, most recently
from
70e68bf to
5214926
Compare
agatha197
force-pushed
the
feature/batch-session-timeout
branch
4 times, most recently
from
b4b6bbd to
e67a827
Compare
yomybaby
requested changes
Nov 14, 2024
yomybaby
requested changes
Nov 14, 2024
yomybaby
force-pushed
the
feature/batch-session-timeout
branch
from
e67a827 to
4b90096
Compare
yomybaby
approved these changes
Nov 14, 2024
Merge activity
|
resolves #2812 related PR: lablup/backend.ai#3066 Add batch job timeout duration to the session launcher. User can select the time unit and input the timeout duration. **How to test:** > test endpoint: 10.82.230.49 1. Modify the support version of `batch-timeout` in `backend.ai-client-esm` for testing. (24.09) 2. Set session type to the batch. 3. Enable `Batch Job Timeout Duration` - eg start command: sleep 20 && echo \"hello world\" timeout: 3s **Checklist:** - [ ] Batch job timeout value remains after refreshing - [ ] The 'Confirm and Launch' page has the same value if you set the 'Batch job timeout duration'. - [ ] (API is not implemented yet) Create a new session with batch session timeout option. **Screentshots:**      **Checklist:** - [ ] Documentation - [ ] Test case: Verify timeout can be enabled/disabled - [ ] Test case: Confirm time picker accepts valid duration formats - [ ] Test case: Check default value initialization - [ ] Test case: Validate timeout enforcement on batch sessions
agatha197
force-pushed
the
feature/batch-session-timeout
branch
from
97b638e to
b082f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2812
related PR: lablup/backend.ai#3066
Add batch job timeout duration to the session launcher.
User can select the time unit and input the timeout duration.
How to test:
batch-timeoutinbackend.ai-client-esmfor testing. (24.09)Batch Job Timeout Durationstart command: sleep 20 && echo "hello world"
timeout: 3s
Checklist:
Screentshots:
Checklist: