Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to provide password for networkresources #1407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flxzt
Copy link
Contributor

@flxzt flxzt commented May 16, 2024

Description

This adds the ability to specify a connection ssh password for resources that derive NetworkResource in order to use them on hosts where adding a ssh key is not possible or where the host key is regenerated after a reboot.

The implementation uses SSH_ASK_PASS in the same way as it is already done in SSHDriver.

Checklist

  • Tests for the feature
  • PR has been tested

@flxzt flxzt force-pushed the networkresource-password branch from a9f1264 to da968fb Compare May 17, 2024 07:54
@Emantor
Copy link
Member

Emantor commented Jun 17, 2024

This PR modifies the utility SSHManager which manages port forwarding, I don't think this is mergable since hosts used for ssh forwarding should be fundamentally under your control and the addition of SSH keys should not be a problem.

The other part I don't like is adding infrastructure passwords to the YAML, you should really be using public key authentication for this infrastructure.

@flxzt
Copy link
Contributor Author

flxzt commented Jun 17, 2024

Hm, I think you're seeing NetworkResources always in the context of the coordinator/exporter infrastructure. It's essentially the same discussion as in #1398 , I always think they could also be used in a more general way to access resources on any remotely accessible system..

Like : the exporter is just a service that happens to export local resources as network resources (and yes, should be easily connectable through passwordless ssh keypairs), but network resources themselves are not bound to only be created by the exporter.

This is a real use case here and works well for me already with this addition (and another one which implements ssh jumps)..

@flxzt flxzt force-pushed the networkresource-password branch from da968fb to 5a8a805 Compare June 18, 2024 07:49
@flxzt flxzt force-pushed the networkresource-password branch from 5a8a805 to 4bf2529 Compare August 19, 2024 08:26
@flxzt flxzt force-pushed the networkresource-password branch from 4bf2529 to 7fa59bb Compare August 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants