Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

[HOTFIX] Adjust deployment identifier for systems #3919

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[HOTFIX] Adjust deployment identifier for systems #3919

merged 1 commit into from
Jun 14, 2024

Conversation

dragobt
Copy link
Contributor

@dragobt dragobt commented Jun 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Adjust system fetcher e2e test for the new deployment identifier for systems

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@dragobt dragobt requested a review from a team as a code owner June 14, 2024 12:02
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dragobt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot requested review from alextargov and dzahariev June 14, 2024 12:02
@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2024
@dragobt dragobt changed the base branch from main to hotfix-v1.96.0 June 14, 2024 12:08
@dragobt dragobt merged commit 668c105 into hotfix-v1.96.0 Jun 14, 2024
2 of 3 checks passed
@dragobt dragobt deleted the fix-deployment-identifier branch June 14, 2024 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alextargov alextargov Awaiting requested review from alextargov

@dzahariev dzahariev Awaiting requested review from dzahariev

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. 🦅 team-falcon Team Falcon Label size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragobt @kyma-bot