Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Improve system fetcher e2e tests #3898

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Improve system fetcher e2e tests #3898

merged 7 commits into from
Jun 4, 2024

Conversation

dragobt
Copy link
Contributor

@dragobt dragobt commented May 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Make the page system fetcher page size smaller for e2e tests

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@dragobt dragobt requested a review from a team as a code owner May 28, 2024 11:42
@kyma-bot kyma-bot requested a review from dzahariev May 28, 2024 11:42
@kyma-bot kyma-bot added the 🦅 team-falcon Team Falcon Label label May 28, 2024
@kyma-bot kyma-bot requested a review from KirilKabakchiev May 28, 2024 11:42
@kyma-bot kyma-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2024
@dragobt dragobt added the 👋 request review Review required label May 28, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2024
@dragobt dragobt changed the title Increase time for system fetcher e2e tests Improve system fetcher e2e tests May 30, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 4, 2024
@kyma-bot
Copy link

kyma-bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaloyanspiridonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ognyvrac ognyvrac removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@kyma-bot kyma-bot merged commit 10db74b into main Jun 4, 2024
3 checks passed
@dragobt dragobt deleted the NGPBUG-390557 branch June 4, 2024 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaloyanspiridonov kaloyanspiridonov kaloyanspiridonov approved these changes

@dzahariev dzahariev Awaiting requested review from dzahariev

@KirilKabakchiev KirilKabakchiev Awaiting requested review from KirilKabakchiev

Assignees

@kaloyanspiridonov kaloyanspiridonov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dragobt @kyma-bot @kaloyanspiridonov @ognyvrac