Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Keep track of operations per formation assignment #3869

Merged
merged 38 commits into from
May 14, 2024
Merged

Conversation

nyordanoff
Copy link
Contributor

@nyordanoff nyordanoff commented May 10, 2024

Description

Currently, we are not storing any information about the current (or past) operations happening on an assignment. We use the state to calculate what was the last operation that happened whenever we need that information: this results in states like: CREATE_ERROR, CREATE_READY, DELETE_ERROR, DELETE_READY, etc...

This PR introduces the new assignment_operation entity and manages its lifecycle. The operation can be either ASSIGN or UNASSIGN.

Changes proposed in this pull request:

  • introduce assignment_operation entity along with dataloaders, service and repo layer
  • the assignment_operation entity has some fields entirely for troubleshooting purposes for the future - triggered_by, started/finished_at_timestamps
  • create assignment_operation for all existing FAs based on their state
  • manage operation lifecycle (create/update/delete) - on assign/unassign/resync/reset/status report
  • rewrite some notification e2e tests in the new test format

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@nyordanoff nyordanoff requested review from a team as code owners May 10, 2024 14:28
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@kyma-bot kyma-bot requested a review from DimitarPetrov May 10, 2024 14:28
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@ognyvrac
Copy link
Contributor

/unhold

@ognyvrac
Copy link
Contributor

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@kyma-bot
Copy link

kyma-bot commented May 13, 2024

@nyordanoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark b20ac95 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nyordanoff nyordanoff added the 👋 request review Review required label May 14, 2024
dzahariev
dzahariev previously approved these changes May 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 14, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 14, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dzahariev, StanislavStefanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@nyordanoff
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@kyma-bot kyma-bot merged commit fe0dee8 into main May 14, 2024
9 checks passed
@nyordanoff nyordanoff deleted the introduce-operations branch May 14, 2024 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. 🦖 team-raptor Team Raptor Label 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants