Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix scopes synchronizer scheduling #3864

Merged
merged 1 commit into from
May 10, 2024
Merged

Fix scopes synchronizer scheduling #3864

merged 1 commit into from
May 10, 2024

Conversation

ognyvrac
Copy link
Contributor

@ognyvrac ognyvrac commented May 9, 2024

Description
Currently, the scopes synchronizer job is only scheduled if there are changes within the config.yaml found in the chart directory of the director. This behvaiour is expected as the clientCredentialsRegistrationGrantTypes is used by the synchronizer.

Previoulsy the scopes were also present in this config.yaml; however, the scopes were moved to the global Helm overrides under global.scopes. The synchronizer is not following the new scopes overrides and is not scheduled whenever they are changed in the Helm values, which is not the expected behvaiour.

Changes proposed in this pull request:

  • add additional checksum to follow for changes under .Values.global.scopes

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@ognyvrac ognyvrac added 👋 request review Review required 🦖 team-raptor Team Raptor Label labels May 9, 2024
@ognyvrac ognyvrac requested review from a team as code owners May 9, 2024 13:47
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2024
@kyma-bot
Copy link

kyma-bot commented May 9, 2024

@ognyvrac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 5f17b7b link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PetarTodorovv PetarTodorovv self-assigned this May 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 10, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PetarTodorovv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@kyma-bot kyma-bot merged commit ad5e2f9 into main May 10, 2024
4 of 5 checks passed
@ognyvrac ognyvrac deleted the scopessynchronizer-fix branch May 10, 2024 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants