Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

System Field Discovery via Operations Manager #3858

Merged
merged 30 commits into from
May 21, 2024
Merged

System Field Discovery via Operations Manager #3858

merged 30 commits into from
May 21, 2024

Conversation

dragobt
Copy link
Contributor

@dragobt dragobt commented Apr 30, 2024 •
edited by kaloyanspiridonov
Loading

Description

Changes proposed in this pull request:

  • Make the System Field Discovery engine to work with the Operations Manager instead of working with go routines
  • Introduce new SYSTEM_FIELD_DISCOVERY_SAAS operation.

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@dragobt dragobt requested review from a team as code owners April 30, 2024 10:11
@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label cla: yes Indicates the PR's author has signed the CLA. labels Apr 30, 2024
@dragobt dragobt added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed 🦅 team-falcon Team Falcon Label cla: yes Indicates the PR's author has signed the CLA. labels Apr 30, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Apr 30, 2024
@kyma-bot kyma-bot added the 🦅 team-falcon Team Falcon Label label Apr 30, 2024
kaloyanspiridonov
kaloyanspiridonov reviewed May 8, 2024
View reviewed changes
components/director/cmd/ordaggregator/main.go Outdated Show resolved Hide resolved
components/director/cmd/systemfetcher/main.go Outdated Show resolved Hide resolved
components/director/cmd/tenantfetcher-svc/main.go Outdated Show resolved Hide resolved
components/director/cmd/tenantfetcher-svc/main.go Outdated Show resolved Hide resolved
components/director/cmd/tenantfetcher-svc/main.go Outdated Show resolved Hide resolved
components/director/internal/system-field-discovery-engine/operation_processor.go Outdated Show resolved Hide resolved
components/director/internal/system-field-discovery-engine/apiclient/client.go Outdated Show resolved Hide resolved
components/director/internal/system-field-discovery-engine/apiclient/client.go Show resolved Hide resolved
components/director/internal/system-field-discovery-engine/service.go Show resolved Hide resolved
components/director/internal/system-field-discovery-engine/service.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 9, 2024
@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@ognyvrac
Copy link
Contributor

/hold

@dragobt
Copy link
Contributor Author

dragobt commented May 16, 2024

delete components/director/internal/system-field-discovery-engine/testdata/TestSystemFieldDiscoveryEngine_data.golden if its not used

@kyma-bot
Copy link

kyma-bot commented May 16, 2024 •
edited
Loading

@dragobt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-smoke-test 4681a5b link true /test pre-main-compass-smoke-test
pre-main-compass-gke-benchmark 4681a5b link false /test pre-main-compass-gke-benchmark
pre-main-compass-integration-no-dump 4681a5b link true /test pre-main-compass-integration-no-dump

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kaloyanspiridonov kaloyanspiridonov added the 👋 request review Review required label May 16, 2024
@dragobt dragobt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emmakarova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@kyma-bot kyma-bot merged commit 4d0b250 into main May 21, 2024
9 checks passed
@dragobt dragobt deleted the CMP-5505 branch May 21, 2024 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaloyanspiridonov kaloyanspiridonov kaloyanspiridonov left review comments

@emmakarova emmakarova emmakarova approved these changes

@dzahariev dzahariev Awaiting requested review from dzahariev

Assignees

@emmakarova emmakarova

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dragobt @ognyvrac @kyma-bot @kaloyanspiridonov @emmakarova