Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Remove some operations-controller alerts #3855

Merged
merged 1 commit into from
May 9, 2024
Merged

Remove some operations-controller alerts #3855

merged 1 commit into from
May 9, 2024

Conversation

kaloyanspiridonov
Copy link
Contributor

@kaloyanspiridonov kaloyanspiridonov commented Apr 29, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove OperationInProgressNearTimeout alert for the operations-controller
  • Remove OperationGotErrorCondition alert for the operations-controller

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@kaloyanspiridonov kaloyanspiridonov requested review from a team as code owners April 29, 2024 07:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@kaloyanspiridonov
Copy link
Contributor Author

/test pre-main-compass-integration-no-dump

@kyma-bot
Copy link

@kaloyanspiridonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark e475684 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaloyanspiridonov kaloyanspiridonov added the 👋 request review Review required label Apr 29, 2024
@alextargov alextargov self-assigned this Apr 29, 2024
@alextargov alextargov added 🦅 team-falcon Team Falcon Label do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 30, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alextargov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@kaloyanspiridonov kaloyanspiridonov added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 9, 2024
@kyma-bot kyma-bot merged commit 2803c64 into main May 9, 2024
4 of 5 checks passed
@kaloyanspiridonov kaloyanspiridonov deleted the remove-alerts branch May 9, 2024 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alextargov alextargov alextargov approved these changes

@PetarTodorovv PetarTodorovv Awaiting requested review from PetarTodorovv

@stefan-sto stefan-sto Awaiting requested review from stefan-sto

Assignees

@alextargov alextargov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaloyanspiridonov @kyma-bot @alextargov