Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

E2E dest fetcher fixes #3852

Merged
merged 12 commits into from
Apr 29, 2024
Merged

E2E dest fetcher fixes #3852

merged 12 commits into from
Apr 29, 2024

Conversation

alextargov
Copy link
Contributor

@alextargov alextargov commented Apr 25, 2024

Description

Changes proposed in this pull request:

  • Revert logic for the client in the tests
  • Revert usage of the APP_DESTINATION_CONSUMER_SUBDOMAIN_MTLS variable
  • Ensure that destination fetcher knows about "old" and "new" correlation ID properties
  • Adapt ext-svc-mock to use headers instead of authorization tokens
  • Unit test adaptations

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@kyma-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2024
@alextargov alextargov marked this pull request as ready for review April 25, 2024 11:15
@alextargov alextargov requested review from a team as code owners April 25, 2024 11:15
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2024
@kyma-bot kyma-bot added the 🦖 team-raptor Team Raptor Label label Apr 25, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2024
@alextargov alextargov changed the title poc dest fetcher property E2E dest fetcher fixes Apr 29, 2024
@alextargov alextargov added the 👋 request review Review required label Apr 29, 2024
@kyma-bot
Copy link

@alextargov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 69e911c link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 29, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emmakarova, la4ezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@kyma-bot kyma-bot merged commit d6d012e into main Apr 29, 2024
11 of 12 checks passed
@la4ezar la4ezar deleted the poc-dest-fetcher-prop branch April 29, 2024 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants