Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Add global app read scope to tenant_discovery_operator #3851

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add global app read scope to tenant_discovery_operator #3851

merged 1 commit into from
Apr 25, 2024

Conversation

petar-iv
Copy link
Contributor

@petar-iv petar-iv commented Apr 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add the scope for global application reading to tenant discovery operator consumer type

Related issue(s)

  • N/A

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@petar-iv petar-iv requested review from a team as code owners April 25, 2024 07:48
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 25, 2024
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 25, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaloyanspiridonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@kyma-bot kyma-bot merged commit 92e9cf4 into main Apr 25, 2024
4 of 5 checks passed
@petar-iv petar-iv deleted the tenant-discovery-scopes branch April 25, 2024 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaloyanspiridonov kaloyanspiridonov kaloyanspiridonov approved these changes

@alexpenev-s alexpenev-s Awaiting requested review from alexpenev-s

@dzahariev dzahariev Awaiting requested review from dzahariev

Assignees

@kaloyanspiridonov kaloyanspiridonov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petar-iv @kyma-bot @kaloyanspiridonov