Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Enrich the tenant mapping request body logs in the instance creator c… #3842

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented Apr 22, 2024

Description
Enrich the logs in the instance creator component with more info about the tenant mapping notification's request body for easier debugging

Changes proposed in this pull request:

  • Enrich the tenant mapping request body with all available fields that don't have sensitive information and log them during request processing

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv requested review from a team as code owners April 22, 2024 06:55
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. 🦖 team-raptor Team Raptor Label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2024
@PetarTodorovv PetarTodorovv added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. 👋 request review Review required labels Apr 22, 2024
@PetarTodorovv PetarTodorovv added 👋 request review Review required and removed 👋 request review Review required do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 22, 2024
@PetarTodorovv PetarTodorovv self-assigned this Apr 24, 2024
@PetarTodorovv PetarTodorovv added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@kyma-bot
Copy link

@PetarTodorovv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 77f3a59 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PetarTodorovv PetarTodorovv assigned nyordanoff and unassigned la4ezar Apr 25, 2024
nyordanoff
nyordanoff previously approved these changes Apr 26, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2024
@kyma-bot kyma-bot removed lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2024
@PetarTodorovv PetarTodorovv removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 26, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nyordanoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@kyma-bot kyma-bot merged commit 4bf9d6c into main Apr 26, 2024
7 of 8 checks passed
@PetarTodorovv PetarTodorovv deleted the tm-log-improvements branch April 26, 2024 08:49
@PetarTodorovv PetarTodorovv removed the 👋 request review Review required label Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants