-
Notifications
You must be signed in to change notification settings - Fork 82
Enrich logger with additional tracing information #3841
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dzahariev, ivantenevvasilev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@PetarTodorovv: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
This PR aims to enrich the logger entries with additional information(
formation-id
andformation-assignment-id
) when there are operations related to these entities. That will improve the logs and debugging and will help us to trace what happened a lot quicker/easier. Also, we already had the Istio distributed tracing headers/data in the context, with this PR I extend the logger info with that data too.Changes proposed in this pull request:
formation-id
and/orformation-assignment-id
entries with their respective IDs in the loggertrace ID
,span ID
andparent span ID
. And the logger was enriched with the mentioned IDs.Related issue(s)
Pull Request status
chart/compass/values.yaml
is updated