Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Enrich logger with additional tracing information #3841

Merged
merged 15 commits into from
Apr 26, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented Apr 22, 2024

Description
This PR aims to enrich the logger entries with additional information(formation-id and formation-assignment-id) when there are operations related to these entities. That will improve the logs and debugging and will help us to trace what happened a lot quicker/easier. Also, we already had the Istio distributed tracing headers/data in the context, with this PR I extend the logger info with that data too.

Changes proposed in this pull request:

  • In the main locations/operations - create/delete formation, assign, unassign, resync, finalize mutation, and "status API" operations I added formation-id and/or formation-assignment-id entries with their respective IDs in the logger
  • Created a couple of helper functions for the trace ID, span ID and parent span ID. And the logger was enriched with the mentioned IDs.

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv self-assigned this Apr 22, 2024
@PetarTodorovv PetarTodorovv requested review from a team as code owners April 22, 2024 06:27
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. 🦖 team-raptor Team Raptor Label labels Apr 22, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2024
@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2024
@PetarTodorovv PetarTodorovv changed the title Enrich logger with additional information Enrich logger with additional tracing information Apr 22, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 23, 2024
@PetarTodorovv PetarTodorovv added the 👋 request review Review required label Apr 24, 2024
dzahariev
dzahariev previously approved these changes Apr 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 24, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 24, 2024
dzahariev
dzahariev previously approved these changes Apr 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 25, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 25, 2024
@PetarTodorovv PetarTodorovv requested a review from dzahariev April 25, 2024 11:22
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 25, 2024
@PetarTodorovv PetarTodorovv removed the 👋 request review Review required label Apr 25, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dzahariev, ivantenevvasilev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@kyma-bot
Copy link

kyma-bot commented Apr 26, 2024

@PetarTodorovv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 6e64661 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 7a7b95a into main Apr 26, 2024
23 of 25 checks passed
@PetarTodorovv PetarTodorovv deleted the add-formation-and-assignment-ids-in-logs branch April 26, 2024 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants