[dev-main fix] Fix cert based tests #3824
Conversation
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
🦖 team-raptor
kyma-bot
removed
the
do-not-merge/work-in-progress
| @@ -819,7 +819,7 @@ func TestORDServiceSystemDiscoveryByApplicationTenantID(t *testing.T) { | |||
| certSubject := strings.Replace(conf.ExternalCertProviderConfig.TestExternalCertSubject, conf.ExternalCertProviderConfig.TestExternalCertCN, "ord-svc-system-discovery", -1) | |||
|
|
|||
| // We need an externally issued cert with a subject that is not part of the access level mappings | |||
| externalCertProviderConfig := createExternalConfigProvider(certSubject) | |||
| externalCertProviderConfig := createExternalConfigProvider(certSubject, conf.CertSvcInstanceTestSecretName) | |||
There was a problem hiding this comment.
I have some questions/concerns about those two tests - TestORDServiceSystemDiscoveryByApplicationTenantID and TestORDServiceSystemDiscoveryByApplicationTenantIDUsingProviderCSM but for now I'll approve the PR so we can proceed with the next steps. After that, we can follow up on that
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PetarTodorovv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kyma-bot
added
the
approved
|
@alextargov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
Description
Changes proposed in this pull request:
Related issue(s)
Pull Request status
chart/compass/values.yamlis updated