Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix IAS adapter async response #3815

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Fix IAS adapter async response #3815

merged 3 commits into from
Apr 16, 2024

Conversation

ZdravkoGyurov
Copy link
Contributor

@ZdravkoGyurov ZdravkoGyurov commented Apr 15, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • ...

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@ZdravkoGyurov ZdravkoGyurov added 👋 request review Review required 🌐 team-atlas Team Atlas label labels Apr 15, 2024
@ZdravkoGyurov ZdravkoGyurov requested a review from a team as a code owner April 15, 2024 12:10
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Apr 15, 2024
@ZdravkoGyurov ZdravkoGyurov requested review from a team as code owners April 15, 2024 12:27
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 15, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: georgifarashev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@ZdravkoGyurov
Copy link
Contributor Author

/retest

2 similar comments
@ZdravkoGyurov
Copy link
Contributor Author

/retest

@georgifarashev
Copy link
Contributor

/retest

@kyma-bot
Copy link

kyma-bot commented Apr 16, 2024 •
edited
Loading

@ZdravkoGyurov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 3929d86 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZdravkoGyurov
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot merged commit 3b4707c into main Apr 16, 2024
7 of 8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgifarashev georgifarashev georgifarashev approved these changes

@yordanovagabriela yordanovagabriela Awaiting requested review from yordanovagabriela

Assignees

@georgifarashev georgifarashev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🌐 team-atlas Team Atlas label lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZdravkoGyurov @kyma-bot @georgifarashev