Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix request body validation when assignment status is reported #3814

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented Apr 15, 2024

Description
In the "status API" when someone reports status for assignment we incorrectly interpret the configuration property when it's set to null. And it seems the config is provided whereas it should be empty/null, resulting in a request body validation error.

Changes proposed in this pull request:

  • Check for different "empty" values in the request body's configuration property

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv added the 👋 request review Review required label Apr 15, 2024
@PetarTodorovv PetarTodorovv self-assigned this Apr 15, 2024
@PetarTodorovv PetarTodorovv requested review from a team as code owners April 15, 2024 07:33
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. 🦖 team-raptor Team Raptor Label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 17, 2024
@PetarTodorovv PetarTodorovv removed the 👋 request review Review required label Apr 17, 2024
@kyma-bot kyma-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2024
@ognyvrac ognyvrac removed the lgtm Looks good to me! label Apr 17, 2024
@ognyvrac
Copy link
Contributor

/test pre-main-compass-integration-no-dump

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@PetarTodorovv PetarTodorovv force-pushed the fix-fa-req-body-validation branch from e9e83ec to ba0c709 Compare April 17, 2024 11:22
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivantenevvasilev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@kyma-bot
Copy link

kyma-bot commented Apr 17, 2024

@PetarTodorovv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 7d52233 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit e94c237 into main Apr 17, 2024
7 of 9 checks passed
@PetarTodorovv PetarTodorovv deleted the fix-fa-req-body-validation branch April 17, 2024 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants