Expose the region of a System Instance in UCL Discovery Service #3785
Conversation
kyma-bot
added
cla: yes
|
/retest |
| @@ -0,0 +1,65 @@ | |||
| BEGIN; | |||
There was a problem hiding this comment.
Rename both migrations because new ones with bigger timestamp were merged in main.
| COALESCE(labels_app.value, labels_tmpl.value) AS region, | ||
| apps.local_tenant_id, | ||
| tmpl.name AS product_type, | ||
| formation_details.formation_id, -- this may seem as a duplicate of 't_apps.formation_id' but is not, because 't_apps.formation_id' can have default value but 'formation_details.formation_id' will always have the 'real' formation id |
There was a problem hiding this comment.
Could you delete all comments in both migrations because they were added in a previous PR and the whole context of the comments is related to that PR. If we keep them in every future migration where tenants_apps is changed, I think it will just make the view/migration more difficult to read.
|
reminder: apply the respective down migration on prod-copy db and delete your test |
# Conflicts: # chart/compass/values.yaml
|
/test pre-main-compass-integration-no-dump |
1 similar comment
|
/test pre-main-compass-integration-no-dump |
|
@la4ezar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pre-main-compass-schema-migrator-validate |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nyordanoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kyma-bot
added
the
approved
Description
We want the Discovery Service consumers to see the region of a system instance so that they can uniquely identify it based on its namespace (applicationNamespace), region (deploymentRegion), and localId (applicationTenantId).
Changes proposed in this pull request:
Related issue(s)
Pull Request status
chart/compass/values.yamlis updated