This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
[HOTFIX] Instance Creator - Fix logging, add role for its certificate and fix handler bug #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handler bug (#3662) * Add role for the instance creator certificate and fix logging * Update values.yaml * Fix copy paste errors * Fix copy paste errors * Fix bug * Fix responding with error in the handler * Fix bug * Fix logging * Fix parameters key * Fix unit tests * Adjust unit test name * fix unit tests * bump instance creator PR in values.yaml --------- Co-authored-by: ivanetenevvasilev <[email protected]>
kyma-bot
added
cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hotfix for #3662
Related issue(s)
Pull Request status
chart/compass/values.yamlis updated