Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Make formation participant not required in the GraphQL schema #3595

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

ivantenevvasilev
Copy link
Contributor

Description
Currently it is possible due to other bugs that the application/runtime/runtime context to be deleted without deleting the formation assignments, and in such cases the query will fail.

Changes proposed in this pull request:

  • make formation participant not required in the GraphQL schema

Related issue(s)

Pull Request status

  • Implementation
  • [N/A] Unit tests
  • [N/A] Integration tests
  • chart/compass/values.yaml is updated
  • [N/A] Mocks are regenerated, using the automated script

@ivantenevvasilev ivantenevvasilev requested review from a team as code owners January 23, 2024 08:58
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2024
@ivantenevvasilev ivantenevvasilev added the 👋 request review Review required label Jan 23, 2024
la4ezar
la4ezar previously approved these changes Jan 23, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. and removed lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: la4ezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@kyma-bot kyma-bot merged commit 625928f into main Jan 23, 2024
9 of 10 checks passed
@ivantenevvasilev ivantenevvasilev deleted the relax-formation-participant-schema branch January 23, 2024 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants