This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
Maintain lastUpdate property of ORD resources #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jan 12, 2024
Skipping CI for Draft Pull Request. |
kyma-bot
added
🦅 team-falcon
Team Falcon Label
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 12, 2024
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jan 12, 2024
/retest |
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 12, 2024
/test pre-main-compass-integration-no-dump |
/test pre-main-compass-integration-no-dump |
/retest |
alextargov
approved these changes
Jan 16, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alextargov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kyma-bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cla: yes
Indicates the PR's author has signed the CLA.
🦅 team-falcon
Team Falcon Label
lgtm
Looks good to me!
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
to be released 🚀
👋 request review
Review required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ORD resources have the
lastUpdate
field for saving the information about the time when the resources (or its resource definitions if it has such) have changed since the last aggregation. The lastUpdate is not always maintained by the ORD providers, so UCL now will set the right timestamp regarding the state of the resources.Resources that have the property
lastUpdate
in the ORD spec - API, Event, Consumption Bundle, Capability, Integration Dependency, Entity Type, Data Product.Changes proposed in this pull request:
lastUpdate
to time.Now when creating the resource (on aggregation when the resource is not present in the DB)lastUpdate
comparing its value in the document and in the dblastUpdate
field from the hash of the resourceslastUpdate
to time.NowlastUpdate
field to Consumption bundleRelated issue(s)
Pull Request status
chart/compass/values.yaml
is updated