Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the code of Controller #2266

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

mohamed-rafraf
Copy link
Contributor

@mohamed-rafraf mohamed-rafraf commented Feb 14, 2024

This PR refactors a previously monolithic script into splitted components

Aiming to enhance code maintainability, facilitate easier debugging, and support scalable development. By breaking down the code into focused modules, enabling more straightforward updates, collaborative development

In Order to test the new controller. Build docker image from Dockerfile.complete file!

@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2024
@mohamed-rafraf
Copy link
Contributor Author

/assign @benjaminhuo

@benjaminhuo
Copy link
Member

Thanks @mohamed-rafraf cc @pixiake

@benjaminhuo benjaminhuo requested a review from pixiake February 18, 2024 02:24
@pixiake
Copy link
Collaborator

pixiake commented Feb 19, 2024

@mohamed-rafraf That's Great ! Thnaks

If possible, you can change the Dockerfile in the ci configuration file to Dockerfile.complete.

docker build . --file Dockerfile --tag ks-installer

@mohamed-rafraf
Copy link
Contributor Author

@pixiake Thank you! It's changed!

@pixiake
Copy link
Collaborator

pixiake commented Feb 20, 2024

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f34b3dd2b30107e89806d488bf2b8b7a4ac55489

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohamed-rafraf, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@ks-ci-bot ks-ci-bot merged commit 4ef6750 into kubesphere:master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants