Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: metric guide for ks #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: metric guide for ks #289

wants to merge 1 commit into from

Conversation

xyz-li
Copy link

@xyz-li xyz-li commented Jan 11, 2021 •
edited
Loading

Signed-off-by: LiHui [email protected]

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2021
@xyz-li
Copy link
Author

xyz-li commented Jan 11, 2021 •
edited
Loading

/assign @benjaminhuo

@xyz-li
Copy link
Author

xyz-li commented Jan 11, 2021

/assign @zryfish

metric guide
2dc458c 
Signed-off-by: LiHui <[email protected]>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xyz-li
To complete the pull request process, please assign zryfish
You can assign the PR to them by writing /assign @zryfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xyz-li
Copy link
Author

xyz-li commented Jan 12, 2021

/assign @zryfish

@benjaminhuo benjaminhuo self-requested a review January 12, 2021 06:42
@xyz-li xyz-li requested review from FeynmanZhou and zryfish and removed request for FeynmanZhou January 13, 2021 03:45
benjaminhuo
benjaminhuo reviewed Jan 26, 2021
View reviewed changes
sig-observability/concepts-and-designs/how-to-add-new-metric-to-kubesphere.md
@@ -0,0 +1,61 @@
# Why we need to add metrics to kubesphere

Metrics can provide insight into the behavior and health of our system. They represent the raw material used by monitoring system to build a holistic view of kubesphere, automate responses to changes, and alert human beings when required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add ：

benjaminhuo
benjaminhuo requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@benjaminhuo benjaminhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above, thanks

@xyz-li xyz-li changed the title metric guide for ks WIP: metric guide for ks Mar 26, 2021
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021
@zryfish zryfish mentioned this pull request Dec 1, 2021
Open
@yangchuansheng yangchuansheng force-pushed the master branch 4 times, most recently from 4a41274 to a30f1e3 Compare November 29, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuo benjaminhuo benjaminhuo requested changes

@zryfish zryfish Awaiting requested review from zryfish

Requested changes must be addressed to merge this pull request.

Assignees

@zryfish zryfish

Labels
dco-signoff: yes do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xyz-li @ks-ci-bot @benjaminhuo @zryfish