Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR Link 464 #229

Merged

Conversation

shenhonglei
Copy link
Contributor

Signed-off-by: honglei [email protected]

update PR Link 464

Signed-off-by: honglei <[email protected]>
@shenhonglei
Copy link
Contributor Author

/assign @FeynmanZhou

@ks-ci-bot ks-ci-bot added dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2020
Copy link
Contributor

@rayzhou2017 rayzhou2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rayzhou2017 rayzhou2017 added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 5, 2020
@ks-ci-bot ks-ci-bot merged commit d896257 into kubesphere:master Nov 5, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayzhou2017, shenhonglei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants