Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eidt Task list #219

Merged
merged 1 commit into from
Nov 3, 2020
Merged

eidt Task list #219

merged 1 commit into from
Nov 3, 2020

Conversation

mvpzhangkai
Copy link
Contributor

No description provided.

rayzhou2017
rayzhou2017 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@rayzhou2017 rayzhou2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvpzhangkai, rayzhou2017

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. dco-signoff: no labels Nov 3, 2020
@ks-ci-bot
Copy link
Collaborator

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2020
@rayzhou2017 rayzhou2017 merged commit 2c265a5 into kubesphere:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayzhou2017 rayzhou2017 rayzhou2017 approved these changes

Assignees

@rayzhou2017 rayzhou2017

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: no lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvpzhangkai @ks-ci-bot @rayzhou2017