-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZH-CN Localization Task.md #210
base: master
Are you sure you want to change the base?
Conversation
Added PR links.
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
please sign off your pr by using
|
hi @reneeteng , I'm wondering if you can take some time to fix the dco issues. |
hi @rayzhou2017 and @FeynmanZhou, as we can see here. It's very easy to make some conflicts. Because all people need to update one file. So I'm wondering if we can use an alternative solution to manage these tasks. For example, convert these tasks into issues. |
Yes. The key point is we have to reminder contributors to sign-off commits in advance. Otherwise, our contributors may still have problems when submitting PR to any repo. |
Sorry for the late reply. What should I do now? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: reneeteng The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @calvinyv |
/lgtm |
Any updates? /cc @kubesphere/sig-docs |
/lgtm |
4a41274
to
a30f1e3
Compare
Added PR links.