Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspace group design #179

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Add workspace group design #179

merged 2 commits into from
Nov 3, 2020

Conversation

RolandMa1986
Copy link
Member

Signed-off-by: Roland.Ma [email protected]

@RolandMa1986
Copy link
Member Author

/assign @wansir

@ks-ci-bot
Copy link
Collaborator

@RolandMa1986: GitHub didn't allow me to assign the following users: wansir.

Note that only kubesphere members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wansir

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2020
@wansir
Copy link
Member

wansir commented Oct 13, 2020

/lgtm

@ks-ci-bot
Copy link
Collaborator

@wansir: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RolandMa1986
Copy link
Member Author

/assign @FeynmanZhou
/cc @wansir

@ks-ci-bot
Copy link
Collaborator

@RolandMa1986: GitHub didn't allow me to request PR reviews from the following users: wansir.

Note that only kubesphere members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @FeynmanZhou
/cc @wansir

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rayzhou2017
rayzhou2017 reviewed Oct 31, 2020
View reviewed changes
sig-multitenancy/concepts-and-designs/user-group-designs.md
### User group management of platform level

At the platform level, the user group will be shown as a hierarchical structure of workspace and groups of the workspace. Admins will be able to assign users to a group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to draw a picture here since people is easy to get confused by groups of the workspace

fix typo
91b9d80 
Signed-off-by: Roland.Ma <[email protected]>
rayzhou2017
rayzhou2017 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@rayzhou2017 rayzhou2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayzhou2017, RolandMa1986

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@ks-ci-bot ks-ci-bot merged commit f94a00b into kubesphere:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayzhou2017 rayzhou2017 rayzhou2017 approved these changes

Assignees

@rayzhou2017 rayzhou2017

@FeynmanZhou FeynmanZhou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RolandMa1986 @ks-ci-bot @wansir @rayzhou2017 @FeynmanZhou