Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote LoadBalancerIPMode to GA #47938

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Promote LoadBalancerIPMode to GA #47938

merged 1 commit into from
Oct 11, 2024
+6 −5

Conversation

RyanAoh
Copy link
Member

@RyanAoh RyanAoh commented Sep 15, 2024 •
edited
Loading

Update the docs about promoting LoadBalancerIPMode to GA.

xref:
KEP
kubernetes/kubernetes#127348

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Sep 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2024
@RyanAoh RyanAoh changed the base branch from main to dev-1.32 September 15, 2024 15:53
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2024
@RyanAoh RyanAoh closed this Sep 15, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 15, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 338c7b1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66f0db681ac82300086d51c3

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2024
@RyanAoh
Copy link
Member Author

RyanAoh commented Sep 15, 2024

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Sep 15, 2024
@k8s-ci-robot
Copy link
Contributor

@RyanAoh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 15, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 557c4c0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66e702dd0038a500087a6b22
😎 Deploy Preview https://deploy-preview-47938--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 15, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 338c7b1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f0db68b4a7820008a2c67b
😎 Deploy Preview https://deploy-preview-47938--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Sep 15, 2024

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 15, 2024
sftim
sftim reviewed Sep 15, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please see the inline feedback.

content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/kube-apiserver.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/kube-controller-manager.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/kube-proxy.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/kube-scheduler.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/kubelet.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/service.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2024
@RyanAoh RyanAoh requested a review from sftim September 16, 2024 15:50
@tengqm
Copy link
Contributor

tengqm commented Sep 17, 2024

Please provide a link to the upstream source code change in the commit message.

@RyanAoh
Copy link
Member Author

RyanAoh commented Sep 19, 2024

@tengqm I've updated the commit message.

@tengqm
Copy link
Contributor

tengqm commented Sep 19, 2024

@tengqm I've updated the commit message.

@RyanAoh Please provide link to the source code change, not the KEP. KEPs are too wordy to track. What we want to ensure is that the upstream source code change is proposed and merged.

@RyanAoh
Copy link
Member Author

RyanAoh commented Sep 19, 2024

@tengqm The PR of the upstream source code is kubernetes/kubernetes#127348. I've included it in both the Git commit message and the description of this PR.

@RyanAoh RyanAoh requested a review from tengqm September 23, 2024 03:08
@tengqm
Copy link
Contributor

tengqm commented Sep 25, 2024

/approve
/hold

Hold can be lifted when the upstream change has been merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@RyanAoh
Copy link
Member Author

RyanAoh commented Oct 11, 2024

The upstream change kubernetes/kubernetes#127348 has been merged.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@niranjandarshann
Copy link
Contributor

Looks good to me
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 306585fd993edc3b12c1b37cd2ce33044aff6ff4

@k8s-ci-robot k8s-ci-robot merged commit 0ec5a94 into kubernetes:dev-1.32 Oct 11, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 11, 2024
@pacoxu pacoxu mentioned this pull request Oct 12, 2024
Open
12 tasks
@Eason1118 Eason1118 mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@niranjandarshann niranjandarshann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@RyanAoh @k8s-ci-robot @sftim @tengqm @niranjandarshann