Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote LoadBalancerIPMode to Beta #45219

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Promote LoadBalancerIPMode to Beta #45219

merged 1 commit into from
Feb 28, 2024

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Feb 19, 2024

As part of promotion of LoadBalancerIPMode to Beta, this is a placeholder PR to properly update the docs

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2024
@rikatz
Copy link
Contributor Author

rikatz commented Feb 19, 2024

/hold

This should be merged just after the main code is merged, I will keep this updated here

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dd867da
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65d3d0eb0b4e450008751b00
😎 Deploy Preview https://deploy-preview-45219--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikatz We should consider setting the dev-1.30 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting beta in 1.30.

@rikatz rikatz changed the base branch from main to dev-1.30 February 20, 2024 00:21
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2024
@rikatz
Copy link
Contributor Author

rikatz commented Feb 20, 2024

Hum, did but will need to rebase tomorrow

@rikatz rikatz force-pushed the kep-1860-placeholder branch from dd867da to e60bc6a Compare February 20, 2024 13:05
@netlify Netlify
Copy link

netlify bot commented Feb 20, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ae51660
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65de1c7fdba023000899bfa2

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 20, 2024
@dipesh-rawat
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Feb 21, 2024
@rikatz rikatz force-pushed the kep-1860-placeholder branch from e60bc6a to 0569256 Compare February 22, 2024 12:35
@rikatz
Copy link
Contributor Author

rikatz commented Feb 22, 2024

/hold cancel
kubernetes/kubernetes#123418 is the PR for the feature promotion on k/k

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
@rikatz
Copy link
Contributor Author

rikatz commented Feb 26, 2024

/assign @dipesh-rawat

This is ready to be merged, the PR on k/k is done. Please let me know if there's anything else to be done here :)

@rikatz rikatz mentioned this pull request Feb 26, 2024
Open
12 tasks
dipesh-rawat
dipesh-rawat reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good to me. It would be nice to update the PR description to reflect that it's no longer a placeholder. Reviewers/Approvers can now review it, and mentioning the upstream PR kubernetes/kubernetes#123418 would also be helpful.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e25fc3bd86ea57c9cdeb0af6d0e9223550b6971b

@rikatz rikatz force-pushed the kep-1860-placeholder branch from 0569256 to ae51660 Compare February 27, 2024 17:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@rikatz
Copy link
Contributor Author

rikatz commented Feb 27, 2024

@tengqm change applied as requested

@tengqm
Copy link
Contributor

tengqm commented Feb 28, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@ramrodo
Copy link
Member

ramrodo commented Feb 28, 2024

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c82b090267faa99383d46bcd6cdb0fe1b72f0de6

@k8s-ci-robot k8s-ci-robot merged commit 5e3bedd into kubernetes:dev-1.30 Feb 28, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Mar 15, 2024
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@ramrodo ramrodo

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@rikatz @dipesh-rawat @k8s-ci-robot @tengqm @ramrodo @drewhagen