Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the command exposing the Deployment in the tutorial for scaling an application #44752

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

adityasamant25
Copy link
Contributor

Fixes #44749
The tutorial for Running Multiple Instances of Your App has been improved.
The reader's minikube environment lacks a NodePort service as it is deleted in Step 3 of the previous section.
This PR mentions the command to create the service again, as it is required in the tutorial.

The PR adds a minor fix in the Using a Service to Expose Your App page, as it missed a section labeled as Step 2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 15, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2024
Copy link

netlify bot commented Jan 15, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 14bda6e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65a6534e97283a00097c44e0
😎 Deploy Preview https://deploy-preview-44752--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Even better, we can add emphasis on the note by using a {{<note>}} shortcode

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f477c2813a4e7059ea0f82f6416ee6bc4477c6b

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@adityasamant25
Copy link
Contributor Author

Even better, we can add emphasis on the note by using a {{<note>}} shortcode

@Gauravpadam I agree. I have used the Note shortcode in the latest commit and it looks much better now.
PTAL.

…nd to create the Service if not present.

Specified the Step 2 which was missing earlier.

Added the note inside a shortcode.
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

Preview Page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50808245e95564d0f19a735541ceee8ff6330c8f

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, @adityasamant25 :)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 648d60b into kubernetes:main Jan 16, 2024
6 checks passed
@adityasamant25 adityasamant25 deleted the issue-44749 branch January 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants