-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the command exposing the Deployment in the tutorial for scaling an application #44752
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Even better, we can add emphasis on the note by using a {{<note>}}
shortcode
LGTM label has been added. Git tree hash: 4f477c2813a4e7059ea0f82f6416ee6bc4477c6b
|
@Gauravpadam I agree. I have used the Note shortcode in the latest commit and it looks much better now. |
…nd to create the Service if not present. Specified the Step 2 which was missing earlier. Added the note inside a shortcode.
dc25bcd
to
14bda6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
LGTM label has been added. Git tree hash: 50808245e95564d0f19a735541ceee8ff6330c8f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, @adityasamant25 :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #44749
The tutorial for Running Multiple Instances of Your App has been improved.
The reader's minikube environment lacks a NodePort service as it is deleted in Step 3 of the previous section.
This PR mentions the command to create the service again, as it is required in the tutorial.
The PR adds a minor fix in the Using a Service to Expose Your App page, as it missed a section labeled as
Step 2