-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links related to projection of keys and file permissions in the ConfigMap documentation #44748
Conversation
… keys and file permissions.
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 9098ec9738714af1f21be5adc9b83d1418d966ec
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-merge feedback
[Secrets](/docs/concepts/configuration/secret/#using-secrets-as-files-from-a-pod) | ||
guide explains the syntax. | ||
You can project keys to specific paths. Refer to the corresponding section in the [Secrets](/docs/tasks/inject-data-application/distribute-credentials-secure/#project-secret-keys-to-specific-file-paths) guide for the syntax. | ||
You can set POSIX permissions for keys. Refer to the corresponding section in the [Secrets](/docs/tasks/inject-data-application/distribute-credentials-secure/#set-posix-permissions-for-secret-keys) guide for the syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
[more text here]
### Set POSIX permissions for ConfigMap keys
You can set the POSIX file access permission bits for a single key in a volume
backed by a ConfigMap.
If you don't specify any permissions, `0644` is used by default.
You can also set a default POSIX file mode for the entire ConfigMap volume, and
you can override per key if needed.
For example, you can specify a default mode like this:
```yaml
apiVersion: v1
kind: Pod
metadata:
name: mypod
spec:
containers:
- name: mypod
image: redis
volumeMounts:
- name: foo
mountPath: "/etc/foo"
volumes:
- name: foo
configMap:
configMapName: example-configmap
defaultMode: 0400
The ConfigMap is mounted on /etc/foo
; all the files created by the
ConfigMap volume mount have permission 0400
.
{{< note >}}
If you're defining a Pod or a Pod template using JSON, beware that the JSON
specification doesn't support octal literals for numbers because JSON considers
0400
to be the decimal value 400
. In JSON, use decimal values for the
defaultMode
instead. If you're writing YAML, you can write the defaultMode
in octal.
{{< /note >}}
Fixes #44728
The Configure a Pod to Use a ConfigMap page contains a section called Project keys to specific paths and file permissions.
This section contains a link to a corresponding section in the Secrets guide. The link does not take the user to the precise location.
This PR improves the reader's experience while navigating through this section, by redirecting to the exact locations in the Secrets guide.
Regards,
Aditya