Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up three contribute/generate-ref-docs #44605

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Clean up three contribute/generate-ref-docs #44605

merged 1 commit into from
Jan 4, 2024

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Jan 2, 2024 •
edited
Loading

Performed actions of:

  • providing a consistent look for bullets and headings
  • removing redundant blank lines and spaces
  • fixing typos
  • tweaking long lines

in

content/en/docs/contribute/generate-ref-docs/contribute-upstream.md
content/en/docs/contribute/generate-ref-docs/kubectl.md
content/en/docs/contribute/generate-ref-docs/kubernetes-api.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 2, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d6a8e5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65952f5d7825eb000998903a
😎 Deploy Preview https://deploy-preview-44605--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Soft LGTM.

Overall, I'd switch headings to the imperative form. Consistency is good but I'd pick the other option from what you've chosen here.

content/en/docs/contribute/generate-ref-docs/kubectl.md Outdated Show resolved Hide resolved
content/en/docs/contribute/generate-ref-docs/kubectl.md Outdated Show resolved Hide resolved
content/en/docs/contribute/generate-ref-docs/kubectl.md Outdated Show resolved Hide resolved
content/en/docs/contribute/generate-ref-docs/kubernetes-api.md Outdated Show resolved Hide resolved
content/en/docs/contribute/generate-ref-docs/kubernetes-api.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2024
@windsonsea windsonsea changed the title Clean up two contribute/generate-ref-docs Clean up three contribute/generate-ref-docs Jan 3, 2024
@sftim
Copy link
Contributor

sftim commented Jan 3, 2024

/approve

Thanks for the work on this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@chenrui333
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ebbe65ce6f5d2b1fffc9583fc89cb6b812684e2

@k8s-ci-robot k8s-ci-robot merged commit 1d720dc into kubernetes:main Jan 4, 2024
6 checks passed
@windsonsea windsonsea deleted the checks branch January 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@chenrui333 chenrui333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@windsonsea @sftim @k8s-ci-robot @chenrui333