-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wording around Kata containers and OCI runtime spec #44594
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR titles become commit messages /retitle Improve wording around Kata containers and OCI runtime spec |
/sig node |
295a094
to
5b06481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this appears sufficient to eliminate ambiguity regarding OCI compliance as raised in the issue #40114.
@kubernetes/sig-node-pr-reviews, please review the current proposal and provide any improvements.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dipesh-rawat Although approved, absence of LGTM label is blocking the merge of the PR. Can you add the LGTM as well? |
/lgtm |
LGTM label has been added. Git tree hash: 99b16cde38182c5bc9189639b95bd84b750a7055
|
Fixes #40114
From the Kubernetes documentation standpoint, a minor change in the wording should help clear the ambiguity specified in issue #40114. Instead of stating that Kata Containers is an OCI "compliant" runtime, I'm proposing a change to state that Kata containers "support" the OCI Runtime Specification (from v3.0.2 and above).