Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording around Kata containers and OCI runtime spec #44594

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

adityasamant25
Copy link
Contributor

Fixes #40114

From the Kubernetes documentation standpoint, a minor change in the wording should help clear the ambiguity specified in issue #40114. Instead of stating that Kata Containers is an OCI "compliant" runtime, I'm proposing a change to state that Kata containers "support" the OCI Runtime Specification (from v3.0.2 and above).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 1, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from onlydole January 1, 2024 09:02
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 1, 2024
Copy link

netlify bot commented Jan 1, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b06481
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65e7e9015621250008551b8a
😎 Deploy Preview https://deploy-preview-44594--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jan 1, 2024

PR titles become commit messages

/retitle Improve wording around Kata containers and OCI runtime spec

@k8s-ci-robot k8s-ci-robot changed the title Improved the wording for Kata containers with respect to the OCI runtime specification. Improve wording around Kata containers and OCI runtime spec Jan 1, 2024
@sftim
Copy link
Contributor

sftim commented Jan 1, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 1, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this appears sufficient to eliminate ambiguity regarding OCI compliance as raised in the issue #40114.

@kubernetes/sig-node-pr-reviews, please review the current proposal and provide any improvements.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@adityasamant25
Copy link
Contributor Author

@dipesh-rawat Although approved, absence of LGTM label is blocking the merge of the PR. Can you add the LGTM as well?

@matthyx
Copy link
Contributor

matthyx commented Mar 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99b16cde38182c5bc9189639b95bd84b750a7055

@k8s-ci-robot k8s-ci-robot merged commit a053579 into kubernetes:main Mar 7, 2024
6 checks passed
@adityasamant25 adityasamant25 deleted the issue-40114 branch March 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

https://k8s.io/docs/concepts/security/multi-tenancy incorrectly lists Kata Containers as OCI compliant
5 participants