[WIP] new page for new node in kubernetes cluster #44586

Anuragt1104 · 2023-12-30T19:00:47Z

here is the screenshot of the page being added

linux-foundation-easycla · 2023-12-30T19:00:51Z

The committers listed above are authorized under a signed CLA.

✅ login: Anuragt1104 (db95ca6, f706a31, 72b23de, 90e260d, d72ef9e, 5d5b56e, b6c9fdd, f9913ea, 7ccd649)

k8s-ci-robot · 2023-12-30T19:00:56Z

Welcome @Anuragt1104!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2023-12-30T19:04:29Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7ccd649`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/659e326b87bcb20009e83633
😎 Deploy Preview	https://deploy-preview-44586--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

windsonsea · 2024-01-02T11:37:12Z

Thanks. You only need to provide a preview link rather than screenshots across screens.

windsonsea

Seems this is a draft?

windsonsea · 2024-01-02T11:38:38Z

content/en/docs/tasks/administer-cluster/kubeadm/adding-windows-node.md

+
+
+{{< note >}}
+You must install the `Containers` feature and install Docker. Instructions to do so are available at [Install Docker Engine - Enterprise on Windows Servers]().


Forget to add url in ()?

Thank you for your feedback! I appreciate your attention to detail. I will now add the missing URL in parentheses. Please let me know if there's anything else you'd like me to address.

windsonsea · 2024-01-02T11:40:24Z

content/en/docs/tasks/administer-cluster/kubeadm/adding-windows-node.md

+
+{{< feature-state for_k8s_version="v1.18" state="beta" >}}
+
+You can use Kubernetes to run a mixture of Linux and Windows nodes, so you can mix Pods that run on Linux on with Pods that run on Windows. This page shows how to register Windows nodes to your cluster.


Suggested change

You can use Kubernetes to run a mixture of Linux and Windows nodes, so you can mix Pods that run on Linux on with Pods that run on Windows. This page shows how to register Windows nodes to your cluster.

You can use Kubernetes to run a mixture of Linux and Windows nodes, so you can mix Pods

that run on Linux on with Pods that run on Windows. This page shows how to register

Windows nodes to your cluster.

Tweaking lone lines around 100 - 120 can provide a clean look for review.

windsonsea · 2024-01-02T11:40:49Z

content/en/docs/tasks/administer-cluster/kubeadm/adding-windows-node.md

+
+ {{< version-check >}}
+* Obtain a [Windows Server 2019 license](https://www.microsoft.com/en-us/windows-server/pricing) (or higher) in order to configure the Windows node that hosts Windows containers. If you are using VXLAN/Overlay networking you must have also have [KB4489899](https://support.microsoft.com/en-gb/topic/march-12-2019-kb4489899-os-build-17763-379-2a91a5c5-f351-f181-5501-510308a4030f) installed.
+* A Linux-based Kubernetes kubeadm cluster in which you have access to the control plane (see [Creating a cluster with kubeadm]()).


Forget to add url in ()?

I will look into this also.

made small changes

sftim · 2024-01-03T12:23:02Z

Thank you for your feedback! I appreciate your attention to detail. I will now add the missing URL in parentheses. Please let me know if there's anything else you'd like me to address.

This PR title is “new page for adding node in kubernetes cluster”, but it only covers Windows nodes. Can you explain the discrepancy?

(Kubernetes also supports Linux nodes)

Anuragt1104 · 2024-01-03T12:39:46Z

I'm currently working on the documentation for Linux nodes as well and wanted to streamline the process by submitting a combined pull request. I understand that the current title might not clearly convey this intention.

sftim · 2024-01-03T12:53:35Z

If this is actually a work-in-progress, you can edit the title to start with [WIP]. Or you can mark the PR as a draft.

Anuragt1104 · 2024-01-03T13:39:04Z

Okay.

Anuragt1104 · 2024-01-09T12:22:58Z

Hi @sftim, I'm currently facing challenges in drafting documentation for Linux nodes. I would greatly appreciate assistance from someone experienced in this domain. Alternatively, if someone else feels more comfortable, I'm open to changing the pull request to focus solely on Windows nodes.

sftim · 2024-01-09T13:01:38Z

I'd prefer not to document only the Windows node story, unless we had a clear plan to also cover setting up Linux nodes.

Most Kubernetes clusters use Linux nodes and ignoring that OS would not be ideal.

This reverts commit f9913ea.

k8s-ci-robot · 2024-01-10T06:00:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2024-04-09T06:26:02Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-05-09T07:08:29Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-06-08T07:52:33Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-06-08T07:52:38Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

new page for adding node in kubernetes cluster

db95ca6

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 30, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2023

k8s-ci-robot requested review from natalisucks and tengqm December 30, 2023 19:01

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 30, 2023

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 30, 2023

windsonsea reviewed Jan 2, 2024

View reviewed changes

Anuragt1104 added 4 commits January 2, 2024 17:41

Merge branch 'kubernetes:main' into main

f706a31

made small changes

72b23de

Merge pull request #2 from Anuragt1104/dev2

90e260d

made small changes

Merge branch 'kubernetes:main' into main

d72ef9e

Anuragt1104 requested a review from windsonsea January 3, 2024 12:20

Anuragt1104 changed the title ~~new page for adding node in kubernetes cluster~~ [WIP] new page for adding node in kubernetes cluster Jan 3, 2024

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2024

Anuragt1104 added 2 commits January 8, 2024 16:39

Merge branch 'kubernetes:main' into main

5d5b56e

Merge branch 'kubernetes:main' into main

b6c9fdd

Anuragt1104 changed the title ~~[WIP] new page for adding node in kubernetes cluster~~ new page for Windows Node in kubernetes cluster Jan 9, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2024

Anuragt1104 changed the title ~~new page for Windows Node in kubernetes cluster~~ [WIP] new page for new node in kubernetes cluster Jan 10, 2024

Anuragt1104 added 2 commits January 10, 2024 05:51

moved the info from beta to main list

f9913ea

Revert "moved the info from beta to main list"

7ccd649

This reverts commit f9913ea.

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2024

k8s-ci-robot closed this Jun 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] new page for new node in kubernetes cluster #44586

[WIP] new page for new node in kubernetes cluster #44586

Anuragt1104 commented Dec 30, 2023

linux-foundation-easycla bot commented Dec 30, 2023 •

edited

Loading

k8s-ci-robot commented Dec 30, 2023

netlify bot commented Dec 30, 2023 •

edited

Loading

windsonsea commented Jan 2, 2024

windsonsea left a comment

windsonsea Jan 2, 2024

Anuragt1104 Jan 3, 2024

windsonsea Jan 2, 2024

windsonsea Jan 2, 2024

Anuragt1104 Jan 3, 2024

sftim commented Jan 3, 2024

Anuragt1104 commented Jan 3, 2024

sftim commented Jan 3, 2024

Anuragt1104 commented Jan 3, 2024

Anuragt1104 commented Jan 9, 2024

sftim commented Jan 9, 2024

k8s-ci-robot commented Jan 10, 2024

k8s-triage-robot commented Apr 9, 2024

k8s-triage-robot commented May 9, 2024

k8s-triage-robot commented Jun 8, 2024

k8s-ci-robot commented Jun 8, 2024



		{{< note >}}
		You must install the `Containers` feature and install Docker. Instructions to do so are available at [Install Docker Engine - Enterprise on Windows Servers]().


		{{< feature-state for_k8s_version="v1.18" state="beta" >}}

		You can use Kubernetes to run a mixture of Linux and Windows nodes, so you can mix Pods that run on Linux on with Pods that run on Windows. This page shows how to register Windows nodes to your cluster.

[WIP] new page for new node in kubernetes cluster #44586

[WIP] new page for new node in kubernetes cluster #44586

Conversation

Anuragt1104 commented Dec 30, 2023

linux-foundation-easycla bot commented Dec 30, 2023 • edited Loading

k8s-ci-robot commented Dec 30, 2023

netlify bot commented Dec 30, 2023 • edited Loading

✅ Pull request preview available for checking

windsonsea commented Jan 2, 2024

windsonsea left a comment

Choose a reason for hiding this comment

windsonsea Jan 2, 2024

Choose a reason for hiding this comment

Anuragt1104 Jan 3, 2024

Choose a reason for hiding this comment

windsonsea Jan 2, 2024

Choose a reason for hiding this comment

windsonsea Jan 2, 2024

Choose a reason for hiding this comment

Anuragt1104 Jan 3, 2024

Choose a reason for hiding this comment

sftim commented Jan 3, 2024

Anuragt1104 commented Jan 3, 2024

sftim commented Jan 3, 2024

Anuragt1104 commented Jan 3, 2024

Anuragt1104 commented Jan 9, 2024

sftim commented Jan 9, 2024

k8s-ci-robot commented Jan 10, 2024

k8s-triage-robot commented Apr 9, 2024

k8s-triage-robot commented May 9, 2024

k8s-triage-robot commented Jun 8, 2024

k8s-ci-robot commented Jun 8, 2024

linux-foundation-easycla bot commented Dec 30, 2023 •

edited

Loading

netlify bot commented Dec 30, 2023 •

edited

Loading