Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #44506

Merged
merged 3 commits into from
Jan 2, 2024
Merged

fix typos #44506

merged 3 commits into from
Jan 2, 2024

Conversation

Takashiidobe
Copy link
Contributor

No description provided.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 25, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 25, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 25, 2023
windsonsea
windsonsea reviewed Dec 25, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not directly edit the auto-generated files.

content/en/docs/reference/config-api/apiserver-audit.v1.md Outdated Show resolved Hide resolved
content/en/docs/reference/config-api/kubeadm-config.v1beta4.md Outdated Show resolved Hide resolved
content/en/docs/reference/instrumentation/metrics.md Outdated Show resolved Hide resolved
content/en/docs/reference/kubernetes-api/cluster-resources/api-service-v1.md Outdated Show resolved Hide resolved
content/en/docs/reference/kubernetes-api/config-and-storage-resources/csi-driver-v1.md Outdated Show resolved Hide resolved
content/en/docs/reference/kubernetes-api/config-and-storage-resources/csi-driver-v1.md Outdated Show resolved Hide resolved
content/en/docs/reference/kubernetes-api/service-resources/endpoint-slice-v1.md Outdated Show resolved Hide resolved
@Takashiidobe
Copy link
Contributor Author

Thanks for the feedback, I've undone the changes to the files mentioned.

@netlify Netlify
Copy link

netlify bot commented Dec 25, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a4b705b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/658995360af1510008505800
😎 Deploy Preview https://deploy-preview-44506--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2023
Gauravpadam
Gauravpadam reviewed Dec 25, 2023
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

An lgtm from me; except the one change that is made to an auto-generated page

content/en/docs/reference/config-api/kubeconfig.v1.md Outdated Show resolved Hide resolved
@Gauravpadam
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 25, 2023
@Takashiidobe
Copy link
Contributor Author

hopefully that's the last one, reverted the change to that file

@Takashiidobe
Copy link
Contributor Author

@Gauravpadam if you have time for another look i'd much appreciate it

Gauravpadam
Gauravpadam reviewed Jan 1, 2024
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41fba558eb5164d3cf8e4ec0d0943bf4ab87de50

@reylejano
Copy link
Member

This is a good PR and a good example on how to fix typos. @Takashiidobe went through multiple files to fix typos.
Thank you @Takashiidobe
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit e2509cb into kubernetes:main Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravpadam Gauravpadam Gauravpadam left review comments

@aravindhp aravindhp Awaiting requested review from aravindhp

@cici37 cici37 Awaiting requested review from cici37

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@Gauravpadam Gauravpadam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Takashiidobe @Gauravpadam @k8s-ci-robot @reylejano @windsonsea