Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Localize feature-gates/l*.md #44460

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

windsonsea
Copy link
Member

Related to issue #44410. Localize these files:

  1. legacy-node-role-behavior.md
  2. legacy-service-account-token-clean-up.md
  3. legacy-service-account-token-no-auto-generation.md
  4. legacy-service-account-token-tracking.md
  5. load-balancer-ip-mode.md
  6. local-storage-capacity-isolation-fs-quota-monitoring.md
  7. local-storage-capacity-isolation.md
  8. logarithmic-scale-down.md
  9. logging-alpha-options.md
  10. logging-beta-options.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2023
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Dec 21, 2023
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu December 21, 2023 08:45
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2023
Copy link

netlify bot commented Dec 21, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 90c3dca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65951342d1c38e00088906f5
😎 Deploy Preview https://deploy-preview-44460--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@windsonsea windsonsea force-pushed the gatel branch 2 times, most recently from 6ce9f57 to db6e69b Compare December 25, 2023 09:46
<!--
Allow fine-tuing of experimental, alpha-quality logging options.
-->
允许微调实验性的、Alpha 级别的日志选项。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 alpha 为啥要大写?

Suggested change
允许微调实验性的、Alpha 级别的日志选项。
允许微调实验性的、alpha 级别的日志选项。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文不译的时候,在中文里经常会把首字母改为大写,参照中文本地化风格指南

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments

@chenrui333
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8667b1c00d5ac2698ce07f4f9ec3cd84f5406eab

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8e747e0 into kubernetes:main Jan 4, 2024
6 checks passed
@windsonsea windsonsea deleted the gatel branch January 4, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants