Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced unavailable image in https://k8s.io/docs/tutorials/stateless-application/guestbook/ #44290

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

azn-abel
Copy link
Contributor

resolve #44190

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 10, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2023
Copy link

netlify bot commented Dec 10, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit eda3bed
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6581db7a2100640007517ece
😎 Deploy Preview https://deploy-preview-44290--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azn-abel azn-abel marked this pull request as draft December 10, 2023 06:12
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2023
@azn-abel
Copy link
Contributor Author

Changed the wrong file at first, but fixed it now.

@azn-abel azn-abel marked this pull request as ready for review December 10, 2023 06:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2023
@@ -17,7 +17,7 @@ spec:
spec:
containers:
- name: php-redis
image: gcr.io/google_samples/gb-frontend:v5
image: corelab/gb-frontend:v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that we'd like to suggest an alternative.

  • Why is this container image a good choice / could we switch to another image (maybe one that we, the
    Kubernetes project, control)?
  • please specify the registry; corelab is not a DNS name that resolves.
    I know you mean Docker Hub, but some readers might not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better alternative may be us-docker.pkg.dev/google-samples/containers/gke/gb-frontend:v5, which is now the image used in the original tutorial.. Pasting the link in a browser leads to a Google cloud container registry.

A note could also be added at the top of the .yaml file directing readers to the original tutorial's yaml file if they have run into any trouble with the container image.

If this works, I will update the PR accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azn-abel I like this option. If we can get the page corrected, it will help resolve many duplicate issues which have been logged for this.

#44415 #44224 #44277

Copy link
Contributor Author

@azn-abel azn-abel Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I've corrected the page in a new commit @adityasamant25

Copy link
Contributor

@adityasamant25 adityasamant25 Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azn-abel Looks good to me. However I don't have the permissions to add the lgtm label. Can you please request one of the other reviewers to help?
Also would be great if you could squash the commits into one.

Copy link
Contributor Author

@azn-abel azn-abel Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityasamant25 Thanks - I've squashed the commits. I'll request @sftim for the lgtm label.

Copy link
Contributor

@adityasamant25 adityasamant25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sftim
Copy link
Contributor

sftim commented Dec 19, 2023

Per #44290 (comment)

Why is this container image a good choice / could we switch to another image (maybe one that we, the Kubernetes project, control)?

We'll need an answer to that question.

@azn-abel
Copy link
Contributor Author

azn-abel commented Dec 19, 2023

@sftim

  • The image is a good choice because it's the image that's now used in the original tutorial that the one on k8s.io is based on, and it works well with the rest tutorial. The previous image used was also Google's, but they seem to have taken it down in favor of this updated one.
  • The Kubernetes project doesn't seem to own any compatible images, as the images used in the tutorial (aside from the redis image) are both controlled by Google. Unless we can upload copies of the images to a registry owned by the Kubernetes project the Google ones may be the best option.
  • Also looks like Google replaced the gb-redis-follower currently referenced in the k8s.io tutorial (gcr.io/google_samples/gb-redis-follower:v2) with us-docker.pkg.dev/google-samples/containers/gke/gb-redis-follower:v2. I can go ahead and update this one as well in case the older one is taken down.

@sftim
Copy link
Contributor

sftim commented Jan 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1204b0730ae3d05912c9f67c076df97c8c675f87

@azn-abel
Copy link
Contributor Author

azn-abel commented Jan 2, 2024

/assign @natalisucks

for approval

@adityasamant25
Copy link
Contributor

It would be great to expedite the approval for this PR as it fixes an issue that is repeatedly being reported by multiple users.

Copy link

@kumarankit999 kumarankit999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fixed now!

@azn-abel
Copy link
Contributor Author

azn-abel commented Jan 8, 2024

pinging @natalisucks for approval

@natalisucks
Copy link
Contributor

natalisucks commented Jan 9, 2024

Hi folks – SIG Docs has PR wranglers assigned each week in order to move through the contribution queue of PRs, of which the schedule can be found here: https://github.com/kubernetes/website/wiki/PR-Wranglers

Feel free to ping the relevant PR wrangler in a PR, or in the #sig-docs channel on Kubernetes Slack, to have your work looked at as needed. I can see with the scheduling that Tim has already given his review, and I'm on schedule next week. Unfortunately, the assigned reviewers have yet to respond.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adityasamant25, natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: Deploying PHP Guestbook application with Redis
6 participants