Add comments on Tutorial for not working on ARM architecture cluster #44279
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/sig node |
k8s-ci-robot
added
the
sig/node
There was a problem hiding this comment.
It would be good to have this in a Caution admonition block.
It would be good to have this statement before the "Once you have a running Kubernetes cluster" hyperlink.
Please use |
Thanks for review. |
| @@ -27,6 +27,9 @@ <h3>Objectives</h3> | |||
|
|
|||
| <div class="col-md-8"> | |||
| <h3>Kubernetes Deployments</h3> | |||
|
|
|||
| <p><strong>Please note that Minikube must be used with the Docker Desktop as the driver for running AMD64 images on ARM architecture.</strong></p> | |||
There was a problem hiding this comment.
nit:
I would suggest to use the Note shortcode.
Consider using
{{< note >}}
<p>Minikube must be used with the Docker Desktop as the driver for running AMD64 images on ARM architecture.</p>
{{< /note >}}
There was a problem hiding this comment.
Ack.
I've corrected it into this way.
|
/lgtm |
|
@adityasamant25: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pegasas The changes look good to me, although I'm not entitled to add the lgtm label. |
content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html
Outdated
Show resolved
Hide resolved
…intro.html Co-authored-by: Tim Bannister <[email protected]>
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: da601ed282de3437dfb7997cdc4c985a1ac79051
|
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
It will be good if we can approve and merge this PR as readers on M-series Macbooks are frequently failing on this tutorial. |
|
It's a change to the live site. If someone who's not me, and is an org member, adds their /lgtm, then I can approve it. |
|
/lgtm |
|
@pegasas: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It seems I could not approve my own PR. waiting for owner for merging |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…ubernetes#44279) * Add comments on Tutorial for not working on ARM architecture cluster * Update deploy-intro.html * Update content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html Co-authored-by: Tim Bannister <[email protected]> --------- Co-authored-by: Tim Bannister <[email protected]>
…ubernetes#44279) * Add comments on Tutorial for not working on ARM architecture cluster * Update deploy-intro.html * Update content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html Co-authored-by: Tim Bannister <[email protected]> --------- Co-authored-by: Tim Bannister <[email protected]>
…ubernetes#44279) * Add comments on Tutorial for not working on ARM architecture cluster * Update deploy-intro.html * Update content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html Co-authored-by: Tim Bannister <[email protected]> --------- Co-authored-by: Tim Bannister <[email protected]>
resolve #44271